Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rough draft: attempt to make keep an extra #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justin-f-perez
Copy link
Contributor

@justin-f-perez justin-f-perez commented Mar 20, 2022

attempt to make keep an extra to put it on the PATH when installing via pipx/homebrew

For anyone who might have time to take up the mantle of keeping keep on the PATH here (see #425 for context):

I missed a quote. Let's pretend it was intentional to keep this rush-job from getting merged in ;) I have no experience with setuptools and unfortunately don't have more time to tinker- just stumbled across this potential solution and thought I should share

Of particular interest in #425 thread, last comment: as mentioned, consider use case where user opts not to install keep.

  • Bug fixes

How to test:

I think you should be able to clone this branch, fix the quote, and pipx install .[keep]

Not sure how to test w/ brew

@gleitz feel free to close if this just adds noise to your repo i wont be offended :)

Please provide detailed instructions for testing your changes locally, including expected response/behavior.

Pull Request checklist:

  • Read the contributing_to_howdoi.md
  • Attach screenshots of expected behavior.
  • The changes pass tests locally (nose2).
  • There are no linting errors (python setup.py lint).
  • The changes don't break existing features.
  • Check that there are no confidential files like .env included.
  • Request review from the maintainers.
  • For bug fixes or changes to directory structure, make sure docs are updated.

Known bugs (if any):

If there are bugs in your current changes you can still open the PR and mention the bugs you found. Propose further changes that can help fix bugs in your current changes.

attempt to make `keep` an extra to put it on the PATH when installing via pipx/homebrew
related: gleitz#425
@gleitz
Copy link
Owner

gleitz commented Mar 24, 2022

This is a valiant effort, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants